From mint-bounce@lists.fishpool.fi Fri Sep 30 15:01:46 2005 X-Original-To: fnaumann@mail.boerde.de Delivered-To: fnaumann@mail.boerde.de Subject: [MiNT] menu_popup() ideas From: Odd Skancke To: MiNT List Content-Type: text/plain Date: Fri, 30 Sep 2005 14:58:43 +0000 Message-Id: <1128092323.9497.51.camel@linuxbox> Mime-Version: 1.0 X-Mailer: Evolution 2.0.4 (2.0.4-4) Content-Transfer-Encoding: 7bit X-ecartis-version: Ecartis v1.0.0 Sender: mint-bounce@lists.fishpool.fi Errors-To: mint-bounce@lists.fishpool.fi X-original-sender: ozk@atari.org Precedence: bulk List-help: List-unsubscribe: List-Id: X-List-ID: X-Virus-Scanned: by amavisd-new at relay.boerde.de X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on relay.boerde.de X-Spam-Status: No, hits=2.1 tagged_above=-50.5 required=7.0 tests=BAYES_00, RCVD_IN_SORBS X-Spam-Level: ** Hi list, I have looked at the MENU structure used for menu_popup() call and have found that there are inconsitencies in the documentation. The 'scroll' element is in some documentation said to be enabled when it is set to -1, while other says a value of 1 enabled scroll. However, I think that the correct (and this is how n.aes act) is that a value of -1 enables the popup scroll when it contains more than 8 entries. It has come to my attention that early official documentation from Atari also states 1 as the enable-value, but was changed to -1 in later revisions. After doing some tests, mainly by Lonny, it turns out that N.AES enables scroll when 'scroll' is set to -1, which is correct. Any other value turns scrolling off. XaAES, when only checking for a non-zero value (either 1 or -1), to turn scrolling on/off gave aMail popup (the popup that appears when you click to open 'To:' popup in the send dialog). This does not happen under N.AES. This leads me to the conclusion that as of now, only a 'scroll' value of -1 should enable scroll when more than 8 entries are present. Now for the extention I want to propose; 1. If ('scroll' == -1), enable scrolling when entries > 8 2. If ('scroll' > 1), enable scrolling when entries > ('scroll' < 8 ? 8 : 'scroll') 3. If ('scroll' >= 0 && 'scroll' < 2) then disable scroll. This should not break any existing apps, since I think most apps actually use -1 to enable popup, while offering a way to set the number of entries to the app. This implementation is present in XaAES as of next cvs checkin from me, but if there are strong objections I will remove it again. Ideas? Comments? Best Regards Odd Skancke