From mint-bounce@lists.fishpool.fi Tue Jan 22 17:31:47 2008 X-Original-To: fnaumann@mail.boerde.de Delivered-To: fnaumann@mail.boerde.de Message-ID: <4777E309.8060709@freesbee.fr> Date: Sun, 30 Dec 2007 19:27:21 +0100 From: =?ISO-8859-1?Q?Vincent_Rivi=E8re?= User-Agent: Thunderbird 2.0.0.9 (Windows/20071031) MIME-Version: 1.0 To: mint@fishpool.com Subject: Re: [MiNT] stdio write problem in mintlib References: <20071230010610.GA29673@fairlite.demon.co.uk> <47775FEF.5060708@freesbee.fr> <20071230102935.GB32676@fairlite.demon.co.uk> <20071230142950.GA1737@fairlite.demon.co.uk> <4777C310.40504@freesbee.fr> <20071230170400.GA3566@fairlite.demon.co.uk> In-Reply-To: <20071230170400.GA3566@fairlite.demon.co.uk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-ecartis-version: Ecartis v1.0.0 Sender: mint-bounce@lists.fishpool.fi Errors-To: mint-bounce@lists.fishpool.fi X-original-sender: vincent.riviere@freesbee.fr Precedence: bulk List-help: List-unsubscribe: List-Id: X-List-ID: List-subscribe: List-owner: List-post: X-Virus-Scanned: by amavisd-new at relay.boerde.de X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on relay.boerde.de X-Spam-Status: No, hits=-1.0 tagged_above=-50.5 required=7.0 tests=BAYES_00 X-Spam-Level: Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by freemint id m0MGP1ck004618 Status: X-Status: X-Keywords: Alan Hourihane a écrit : > Can people review ? I see with this patch, a stream turns into binmode if it is not S_ISCHR() (character device : tty, serial...) I think it would be better to use binmode when not S_ISREG() (regular file). Maybe it would be better to use binmode by default, and switch to textmode only if S_ISREG() and UNIXMODE != b. Special care must be taken with the console. I think it should remain in binmode (to be verified), but with special handling to display (and input) everything as expected. With MiNT and TOS. Well, we have to be very careful to avoid regessions... -- Vincent Rivière