From mint-bounce@lists.fishpool.fi Sun Sep 28 19:08:53 2008 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:in-reply-to:mime-version:content-type:references; bh=mSqCy3QSHGMfB6/kQ9GPARic+4QcwCU8UHzaAPTAe4A=; b=LUgV3Cg+9heikUrjf9R65lnVabLvpPgYlN1qTTLa+/TRISdpSghWlA1FPlMXLP65Dq jsyq0pFk4NynJubH2y1Sq3nVKw04L16Hbmbt+cGZZAr7T1LY5ZHOjbhG8Ynlm3yufz61 rwLIg89MNmS0kQDkyq9KKj0VRuD8WsWXeBV1w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version :content-type:references; b=Tzo6Bof7HBW+rkFBcR5hpOlAM2SoHa9vJU8TLPI8S/DvfXwBU7wHMugg42gstgnQW+ XFRbHSokweKCq9gSiPgr/NcBPand0rTudQxHmHf4kwjV3C5WgNBkG9pK8yfWK0ePUlvK A/liGmFWPrxypDqwQvpwf5f2jjTiGh8o3Oyxk= Message-ID: Date: Mon, 29 Sep 2008 00:40:20 +0200 From: "Miro Kropacek" To: mint Subject: Re: [MiNT] Super() calls fixes In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_40949_2726541.1222641620754" References: X-ecartis-version: Ecartis v1.0.0 Sender: mint-bounce@lists.fishpool.fi Errors-to: mint-bounce@lists.fishpool.fi X-original-sender: miro.kropacek@gmail.com Precedence: bulk List-help: List-unsubscribe: List-Id: X-List-ID: List-subscribe: List-owner: List-post: ------=_Part_40949_2726541.1222641620754 Content-Type: multipart/alternative; boundary="----=_Part_40950_25255109.1222641620754" ------=_Part_40950_25255109.1222641620754 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Hm, what about attaching the patch itself :) On Mon, Sep 29, 2008 at 12:38 AM, Miro Kropacek wrote: > Hi, > > in case someone is interested (it seems my previous patches aren't still > included), there's patch to mintlib when the code is in supervisor mode and > it calls for example Getcookie() -- this function another one which calls > Super() under TOS without any check for supervisor presence which leads to > crash. I fixed this situation with all Super() calls I found. Plus some > cosmetic changes. (I'm not sure about that (short) return values -- in > compendium it as WORD but in TOS.HYP it's int32_t... I don't know the > backround so if it's bad, just cut this part of patch away :) > > -- > MiKRO / Mystic Bytes > http://mikro.atari.org > -- MiKRO / Mystic Bytes http://mikro.atari.org ------=_Part_40950_25255109.1222641620754 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline
Hm, what about attaching the patch itself :)

On Mon, Sep 29, 2008 at 12:38 AM, Miro Kropacek <miro.kropacek@gmail.com> wrote:
Hi,

in case someone is interested (it seems my previous patches aren't still included), there's patch to mintlib when the code is in supervisor mode and it calls for example Getcookie() -- this function another one which calls Super() under TOS without any check for supervisor presence which leads to crash. I fixed this situation with all Super() calls I found. Plus some cosmetic changes. (I'm not sure about that (short) return values -- in compendium it as WORD but in TOS.HYP it's int32_t... I don't know the backround so if it's bad, just cut this part of patch away :)

--
MiKRO / Mystic Bytes
http://mikro.atari.org



--
MiKRO / Mystic Bytes
http://mikro.atari.org
------=_Part_40950_25255109.1222641620754-- ------=_Part_40949_2726541.1222641620754 Content-Type: text/x-diff; name=mintlib.patch Content-Transfer-Encoding: base64 X-Attachment-Id: f_flo98v4k0 Content-Disposition: attachment; filename=mintlib.patch SW5kZXg6IGluY2x1ZGUvbWludC9vc2JpbmQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvbWludC9t aW50bGliL2luY2x1ZGUvbWludC9vc2JpbmQuaCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS43CmRp ZmYgLXUgLXIxLjcgb3NiaW5kLmgKLS0tIGluY2x1ZGUvbWludC9vc2JpbmQuaAk2IERlYyAyMDA1 IDE5OjI3OjU1IC0wMDAwCTEuNworKysgaW5jbHVkZS9taW50L29zYmluZC5oCTI4IFNlcCAyMDA4 IDIyOjI0OjMzIC0wMDAwCkBAIC05MzYsMTEgKzkzNiwxMSBAQAogI2RlZmluZQkgICAgICAgQ2Nv bm91dChjKQkJCQkJICAgICAgIFwKICAgICAgICAodm9pZCl0cmFwXzFfd3coKHNob3J0KSgweDAy KSwoc2hvcnQpKGMpKQogI2RlZmluZQkgICAgICAgQ2F1eGluKCkJCQkJCQkgICAgICAgXAotICAg ICAgIChsb25nKXRyYXBfMV93KChzaG9ydCkoMHgwMykpCisgICAgICAgKHNob3J0KXRyYXBfMV93 KChzaG9ydCkoMHgwMykpCiAjZGVmaW5lCSAgICAgICBDYXV4b3V0KGMpCQkJCQkgICAgICAgXAog ICAgICAgICh2b2lkKXRyYXBfMV93dygoc2hvcnQpKDB4MDQpLChzaG9ydCkoYykpCiAjZGVmaW5l CSAgICAgICBDcHJub3V0KGMpCQkJCQkgICAgICAgXAotICAgICAgICh2b2lkKXRyYXBfMV93dygo c2hvcnQpKDB4MDUpLChzaG9ydCkoYykpCisgICAgICAgKHNob3J0KXRyYXBfMV93dygoc2hvcnQp KDB4MDUpLChzaG9ydCkoYykpCiAjZGVmaW5lCSAgICAgICBDcmF3aW8oZGF0YSkJCQkJCSAgICAg ICBcCiAgICAgICAgKGxvbmcpdHJhcF8xX3d3KChzaG9ydCkoMHgwNiksKHNob3J0KShkYXRhKSkK ICNkZWZpbmUJICAgICAgIENyYXdjaW4oKQkJCQkJICAgICAgIFwKQEAgLTk0OCw3ICs5NDgsNyBA QAogI2RlZmluZQkgICAgICAgQ25lY2luKCkJCQkJCQkgICAgICAgXAogICAgICAgIChsb25nKXRy YXBfMV93KChzaG9ydCkoMHgwOCkpCiAjZGVmaW5lCSAgICAgICBDY29ud3MocykJCQkJCSAgICAg ICBcCi0gICAgICAgKHZvaWQpdHJhcF8xX3dsKChzaG9ydCkoMHgwOSksKGxvbmcpKHMpKQorICAg ICAgIChzaG9ydCl0cmFwXzFfd2woKHNob3J0KSgweDA5KSwobG9uZykocykpCiAjZGVmaW5lCSAg ICAgICBDY29ucnMoYnVmKQkJCQkJICAgICAgIFwKICAgICAgICAodm9pZCl0cmFwXzFfd2woKHNo b3J0KSgweDBBKSwobG9uZykoYnVmKSkKICNkZWZpbmUJICAgICAgIENjb25pcygpCQkJCQkJICAg ICAgIFwKSW5kZXg6IGluY2x1ZGUvbWludC9vc3RydWN0LmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTog L21pbnQvbWludGxpYi9pbmNsdWRlL21pbnQvb3N0cnVjdC5oLHYKcmV0cmlldmluZyByZXZpc2lv biAxLjcKZGlmZiAtdSAtcjEuNyBvc3RydWN0LmgKLS0tIGluY2x1ZGUvbWludC9vc3RydWN0LmgJ MjIgSmFuIDIwMDggMDk6MzY6NTQgLTAwMDAJMS43CisrKyBpbmNsdWRlL21pbnQvb3N0cnVjdC5o CTI4IFNlcCAyMDA4IDIyOjI0OjMzIC0wMDAwCkBAIC02NSw5ICs2NSwxMSBAQAogI2RlZmluZSBE RVZfUkVBRFkJCS0xCiAjZGVmaW5lIERFVl9CVVNZCQkwCiAKLS8qIFN1cGVyKCkgbW9kZXMgKi8K LSNkZWZpbmUgU1VQX1NFVAkJCSh2b2lkKikwCi0jZGVmaW5lIFNVUF9JTlFVSVJFCQkodm9pZCop MQorLyogU3VwZXIoKSBjb25zdGFudHMgKi8KKyNkZWZpbmUgU1VQX1NFVAkJCTBMCisjZGVmaW5l IFNVUF9JTlFVSVJFCQkxTAorI2RlZmluZSBTVVBfVVNFUgkJMEwKKyNkZWZpbmUgU1VQX1NVUEVS CQktMUwKIAogLyogRm9wZW4oKSBtb2RlcyAqLwogI2RlZmluZSBTX1JFQUQJCQkweDAwCkluZGV4 OiBtaW50bGliL3N5c3Zhci5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9taW50L21pbnRsaWIvbWlu dGxpYi9zeXN2YXIuYyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4yCmRpZmYgLXUgLXIxLjIgc3lz dmFyLmMKLS0tIG1pbnRsaWIvc3lzdmFyLmMJMjMgSnVsIDIwMDEgMDk6NDE6NTcgLTAwMDAJMS4y CisrKyBtaW50bGliL3N5c3Zhci5jCTI4IFNlcCAyMDA4IDIyOjI0OjM1IC0wMDAwCkBAIC0xMCwx OCArMTAsMjEgQEAKIGdldF9zeXN2YXIgKHZvaWQgKnZhcikKIHsKIAlpZihfX2hhc19ub19zc3lz dGVtKSB7Ci0JCWxvbmcgc2F2ZV9zc3A7CiAJCWxvbmcgcmV0OwotCi0gICAgCQlzYXZlX3NzcCA9 IChsb25nKSBTdXBlcigodm9pZCAqKSAwTCk7CisJCQorCQlpZiAoU3VwZXIoMUwpID09IDBMKSB7 CisJCQlsb25nIHNhdmVfc3NwID0gKGxvbmcpIFN1cGVyKCh2b2lkICopIDBMKTsKIAogCQkvKiBu b3RlOiBkb250IHJlbW92ZSB2b2xhdGlsZSwgb3RoZXJ3aXNlIGdjYyB3aWxsIHJlb3JkZXIgdGhl c2UKIAkJICogc3RhdGVtZW50cyBhbmQgd2UgZ2V0IGJvbWJzICovCiAgICAgCQlyZXQgPSAqKCh2 b2xhdGlsZSBsb25nICopdmFyKTsKIAogICAgIAkJKHZvaWQpU3VwZXIoKHZvaWQgKikgc2F2ZV9z c3ApOworICAgIAl9IGVsc2UgeworICAgIAkJcmV0ID0gKigodm9sYXRpbGUgbG9uZyAqKXZhcik7 CisgICAgCX0KIAotICAgIAkJcmV0dXJuIHJldDsKKyAgICAJcmV0dXJuIHJldDsKIAl9CiAJZWxz ZQogCQlyZXR1cm4gU3N5c3RlbSAoU19HRVRMVkFMLCB2YXIsIE5VTEwpOwpJbmRleDogdW5peC9p b2N0bC5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9taW50L21pbnRsaWIvdW5peC9pb2N0bC5jLHYK cmV0cmlldmluZyByZXZpc2lvbiAxLjEzCmRpZmYgLXUgLXIxLjEzIGlvY3RsLmMKLS0tIHVuaXgv aW9jdGwuYwkxIE1hciAyMDA1IDIzOjI1OjE0IC0wMDAwCTEuMTMKKysrIHVuaXgvaW9jdGwuYwky OCBTZXAgMjAwOCAyMjoyNDozOSAtMDAwMApAQCAtMjEyLDkgKzIxMiwxMyBAQAogICAgICAgICAg ICAgICAgICAgKm1zaWcgfD0gKChnICYgKDEgPDwgNCkpID8gMCA6IFRJT0NNX0RUUik7CiAgICAg ICAgICAgICAgICAgICBtZnAgPSAoKHNob3J0ICopIDB4ZmZmZmZhMDBMKTsKIAkJICBpZiAoX19o YXNfbm9fc3N5c3RlbSkgewotICAgICAgICAgICAgICAgICAgCXNzcCA9IFN1cGVyKDBMKTsKLSAg ICAgICAgICAgICAgICAgIAltID0gKm1mcCAmIDB4ZmY7CisJCSAgCQlpZiAoU3VwZXIoMUwpID09 IDBMKSB7CisJCSAgCQkJc3NwID0gU3VwZXIoMEwpOworICAgICAgICAgICAgICAgIAltID0gKm1m cCAmIDB4ZmY7CiAgICAgICAgICAgICAgICAgICAJU3VwZXIoc3NwKTsKKyAgICAgICAgICAgICAg ICB9IGVsc2UgeworICAgICAgICAgICAgICAgIAltID0gKm1mcCAmIDB4ZmY7CisgICAgICAgICAg ICAgICAgfQogCQkgIH0gZWxzZQogCQkgIAltID0gKHNob3J0KShTc3lzdGVtKFNfVElPQ01HRVQs ICh1X2xvbmcpbWZwLCBOVUxMKSk7CiAgICAgICAgICAgICAgICAgICAqbXNpZyB8PSAoKG0gJiAo MSA8PCAxKSkgPyAwIDogVElPQ01fQ0FSKTsKSW5kZXg6IHVuaXgvc3lzaW5mby5jCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KUkNTIGZpbGU6IC9taW50L21pbnRsaWIvdW5peC9zeXNpbmZvLmMsdgpyZXRyaWV2aW5nIHJl dmlzaW9uIDEuOApkaWZmIC11IC1yMS44IHN5c2luZm8uYwotLS0gdW5peC9zeXNpbmZvLmMJMTUg SnVuIDIwMDggMDk6MDM6MTEgLTAwMDAJMS44CisrKyB1bml4L3N5c2luZm8uYwkyOCBTZXAgMjAw OCAyMjoyNDozOSAtMDAwMApAQCAtMjk3LDEwICsyOTcsMTggQEAKIAogCQlpZiAoU3N5c3RlbSgt MSwgTlVMTCwgTlVMTCkpCiAJCXsKLQkJCXNhdmVfc3RrID0gKHZvaWQgKikgU3VwZXIgKE5VTEwp OwotCQkJc3lzYmFzZSA9ICooKGxvbmcgaW50KiopIDB4MDAwMDA0ZjIpOwotCQkJdG9zdmVyc2lv biA9ICpzeXNiYXNlOwotCQkJKHZvaWQpIFN1cGVyICgodm9pZCopIHNhdmVfc3RrKTsKKwkJCWlm IChTdXBlcigxTCkgPT0gMEwpCisJCQl7CisJCQkJc2F2ZV9zdGsgPSAodm9pZCAqKSBTdXBlciAo MEwpOworCQkJCXN5c2Jhc2UgPSAqKChsb25nIGludCoqKSAweDAwMDAwNGYyKTsKKwkJCQl0b3N2 ZXJzaW9uID0gKnN5c2Jhc2U7CisJCQkJKHZvaWQpIFN1cGVyICgodm9pZCopIHNhdmVfc3RrKTsK KwkJCX0KKwkJCWVsc2UKKwkJCXsKKwkJCQlzeXNiYXNlID0gKigobG9uZyBpbnQqKikgMHgwMDAw MDRmMik7CisJCQkJdG9zdmVyc2lvbiA9ICpzeXNiYXNlOworCQkJfQogCQl9CiAJCWVsc2UKIAkJ ewo= ------=_Part_40949_2726541.1222641620754--