From mint-bounce@lists.fishpool.fi  Sun Mar  1 19:46:33 2009
X-Virus-Scanned: amavisd-new at demon.co.uk
Subject: Re: [MiNT] Gcc 3.3.6 v 4.0.1
From: Alan Hourihane <alanh@fairlite.co.uk>
To: Vincent =?ISO-8859-1?Q?Rivi=E8re?= <vincent.riviere@freesbee.fr>
Cc: mint@fishpool.com
In-Reply-To: <49AB214A.6020802@freesbee.fr>
References: <20090225103817.swnyw26m0wgk8osc@pop.freeola.net>
	 <373EB9E0-576D-4D59-B0A9-829AD39EB08F@gmail.com>
	 <c6533ef60902250323y7091ce02mbb09a78c9bf3c86a@mail.gmail.com>
	 <49A535ED.6000008@freesbee.fr> <49A56B1A.9050304@atari-source.org>
	 <49A5C597.9030003@freesbee.fr>  <49A65413.2020403@freesbee.fr>
	 <1235640237.13634.231.camel@jetpack.demon.co.uk>
	 <49AB214A.6020802@freesbee.fr>
Content-Type: text/plain; charset=UTF-8
Date: Mon, 02 Mar 2009 00:44:50 +0000
Message-Id: <1235954690.25551.96.camel@jetpack.demon.co.uk>
Mime-Version: 1.0
X-Mailer: Evolution 2.22.3.1 
X-ecartis-version: Ecartis v1.0.0
Sender: mint-bounce@lists.fishpool.fi
Errors-to: mint-bounce@lists.fishpool.fi
X-original-sender: alanh@fairlite.co.uk
Precedence: bulk
List-help: <mailto:ecartis@lists.fishpool.fi?Subject=help>
List-unsubscribe: <mailto:mint-request@lists.fishpool.fi?Subject=unsubscribe>
List-Id: <mint.lists.fishpool.fi>
X-List-ID: <mint.lists.fishpool.fi>
List-subscribe: <mailto:mint-request@lists.fishpool.fi?Subject=subscribe>
List-owner: <mailto:tjhukkan@fishpool.fi>
List-post: <mailto:mint@lists.fishpool.fi>
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.sparemint.org id n220kWJE003541

On Mon, 2009-03-02 at 00:59 +0100, Vincent Rivière wrote:
> Alan Hourihane wrote:
> > I think this should fix it.....
> ...
> >  init_obstream (FILE *stream, struct obstack *obstack)
> >  {
> > +  (void) obstack;
> > +
> > +  stream->__magic = _IOMAGIC;
> >    stream->__mode.__write = 1;
> >    stream->__mode.__read = 1;
> 
> Frank, Alan: thank you for your help. I have dug a lot around stdio, and I 
> understood a lot of things.
> 
> I'm currently working on a patch for the MiNTLib, it fixes some gmp 
> testcases, but not yet all of them. I hope it will be finished in a few days.
> 
> Alan, your patch was very good starting point.
> The missing _IOMAGIC value was the first cause of failure. It can't work 
> without it. But adding it is not enough.
> 
> I noticed a "bad smell": you added the following line:
> (void) obstack;
> to avoid compiler warnings about the unused parameter.
> You're right, it isn't used. But it should !

Yes, so doing...

stream->__cookie = (void *)obstack 

isn't enough either ??

Alan.