From mint-bounce@lists.fishpool.fi Mon Nov 30 11:09:44 2009 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:content-type:subject :date:message-id:to:mime-version:x-mailer; bh=O6t/e/CehfgGernwXRV/VdqGes9qo628Lth/19XCYr0=; b=KqA2hqfDL5oDj9AB5cKRTRuOJ+nwygPGxy1ERo2fQl+6ZduL+wcDpb1edGLBjL2a4s nYHn+rbrxVrHlq/xzyTPq9Bae/mtMMJKlKw7wPIYbEz8InDCk5Xb9Y8zFQMlZcGGih1j 20ogbdeQq5rfuaSAA3h2NFL72La/2MzjOaM4o= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:content-type:subject:date:message-id:to:mime-version:x-mailer; b=E+fKnh0ua0gOrfMfIaPSTY1T0CkrhEW9IQIYW8gbNDmiw20oy4dh+cCbrV6wZMuRL1 8PQyPlb4Ba4zTGfFeJwHtHIskx7czGCMKqTAN0mWIv3+iIZBzBjOVtVxnaplhUNJlFr7 P527M+aekfw+LQrKOcj+6OONOIgFJpN5IqeXM= From: Peter Persson Content-Type: multipart/alternative; boundary=Apple-Mail-29--30323703 Subject: [MiNT] XaAES screen init code Date: Mon, 30 Nov 2009 17:07:14 +0100 Message-Id: To: "[MiNT] Mailing-List" Mime-Version: 1.0 (Apple Message framework v1076) X-Mailer: Apple Mail (2.1076) X-ecartis-version: Ecartis v1.0.0 Sender: mint-bounce@lists.fishpool.fi Errors-to: mint-bounce@lists.fishpool.fi X-original-sender: pep.fishmoose@gmail.com Precedence: bulk List-help: List-unsubscribe: List-Id: X-List-ID: List-subscribe: List-owner: List-post: --Apple-Mail-29--30323703 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii; format=flowed; delsp=yes Hi, I stumbled on this in k_init.c: nvmode = vcheckmode(cfg.videomode); if ((nvmode & (1 << 4)) && /* VGA_FALCON */ (nvmode & 7) == 4) /* is 16bit */ { nvmode &= ~(1 << 3); /* Set 320 pixels */ } work_out[45] = nvmode; mode = 5; The (limited) documentation I've found for Vcheckmode() says: - "modify video mode to match the possibilities of the attached monitor." (milan development docs) My impression is that the following code is redundant, since this should already be catered for in Vcheckmode(): if ((nvmode & (1 << 4)) && /* VGA_FALCON */ (nvmode & 7) == 4) /* is 16bit */ { nvmode &= ~(1 << 3); /* Set 320 pixels */ } Does anyone know a better source of information regarding Vcheckmode()? best regards -- PeP --Apple-Mail-29--30323703 Content-Transfer-Encoding: 7bit Content-Type: text/html; charset=us-ascii Hi,

I stumbled on this in k_init.c:

		nvmode = vcheckmode(cfg.videomode);
		if ((nvmode & (1 << 4)) &&	/* VGA_FALCON */
		    (nvmode & 7) == 4)		/* is 16bit */
		{
			nvmode &= ~(1 << 3);		/* Set 320 pixels */
		}
				
		work_out[45] = nvmode;
		mode = 5;


The (limited) documentation I've found for Vcheckmode() says:
 - "modify video mode to match the possibilities of the attached monitor." (milan development docs)

My impression is that the following code is redundant, since this should already be catered for in Vcheckmode():
		if ((nvmode & (1 << 4)) &&	/* VGA_FALCON */
		    (nvmode & 7) == 4)		/* is 16bit */
		{
			nvmode &= ~(1 << 3);		/* Set 320 pixels */
		}
Does anyone know a better source of information regarding Vcheckmode()?

best regards

-- PeP

--Apple-Mail-29--30323703--