From mint-bounce@lists.fishpool.fi Tue Dec 22 12:19:06 2009 Message-ID: <4B30FE9B.30001@freesbee.fr> Date: Tue, 22 Dec 2009 18:15:07 +0100 From: =?ISO-8859-1?Q?Vincent_Rivi=E8re?= User-Agent: Thunderbird 2.0.0.19 (Windows/20081209) MIME-Version: 1.0 To: "mint@lists.fishpool.fi" Subject: [MiNT] Possible bug in cflib's font selector Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-Antivirus: avast! (VPS 091222-0, 22/12/2009), Outbound message X-Antivirus-Status: Clean X-ecartis-version: Ecartis v1.0.0 Sender: mint-bounce@lists.fishpool.fi Errors-to: mint-bounce@lists.fishpool.fi X-original-sender: vincent.riviere@freesbee.fr Precedence: bulk List-help: List-unsubscribe: List-Id: X-List-ID: List-subscribe: List-owner: List-post: Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.sparemint.org id nBMHJ5d6009483 Hello. I have closed this bug because it has been fixed: http://sparemint.org/bugtracker/view.php?id=158 But I looked at the file cflib/fontsel.c and I found a very bad smell in the clobber lists (once again): http://www.atariforge.net/cgi-bin/cvsweb/lib/cflib/fontsel.c?rev=1.5&content-type=text/x-cvsweb-markup I guess the functions xfsl_init(), xfsl_event() and xfsl_exit() are called via assembler functions to cope with the mshort API, right ? I found some documentation here: http://toshyp.atari.org/00d00e.htm#Pure-C_20and_20_27cdecl_27 It says that the API is "Pure C cdecl". Does this mean that the clobbered registers are d0/d1/a0/a1, like GCC ? Do you agree, Henk ? It this is right, d2 should not be present in the clobber lists, and a1 is missing. Even worse for xfsl_exit(). Am I right ? -- Vincent Rivière