From mint-bounce@lists.fishpool.fi  Tue Dec 15 06:51:49 2009
Message-ID: <BAB23262A0FA40C2BC2EF7F5A2D614D4@mercatus.local>
From: "Jo Even Skarstein" <joska@online.no>
To: "[MiNT] Mailing-List" <mint@fishpool.com>
Subject: [MiNT] Programming style
Date: Tue, 15 Dec 2009 12:49:13 +0100
MIME-Version: 1.0
Content-Type: text/plain;
	format=flowed;
	charset="iso-8859-1";
	reply-type=original
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
Importance: Normal
X-Mailer: Microsoft Windows Live Mail 14.0.8089.726
X-MimeOLE: Produced By Microsoft MimeOLE V14.0.8089.726
X-EsetScannerBuild: 6217
X-ecartis-version: Ecartis v1.0.0
Sender: mint-bounce@lists.fishpool.fi
Errors-to: mint-bounce@lists.fishpool.fi
X-original-sender: joska@online.no
Precedence: bulk
List-help: <mailto:ecartis@lists.fishpool.fi?Subject=help>
List-unsubscribe: <mailto:mint-request@lists.fishpool.fi?Subject=unsubscribe>
List-Id: <mint.lists.fishpool.fi>
X-List-ID: <mint.lists.fishpool.fi>
List-subscribe: <mailto:mint-request@lists.fishpool.fi?Subject=subscribe>
List-owner: <mailto:tjhukkan@fishpool.fi>
List-post: <mailto:mint@lists.fishpool.fi>

Hi!

When I implemented the deadkey-stuff in keyboard.c, I noticed that there 
were no static variables inside functions. Global variables are used even 
for variables that are used inside a single function, I would say that a 
local static variable would be better for this. So before I submit my 
patch - must I move the local static variable out of the function, or is 
this OK?

Jo Even 


__________ Information from ESET NOD32 Antivirus, version of virus signature database 4689 (20091215) __________

The message was checked by ESET NOD32 Antivirus.

http://www.eset.com