From mint-bounce@lists.fishpool.fi Sun Apr 11 12:13:58 2010 X-ME-UUID: 20100411161211956.E99B9800012E@mwinf2e07.orange.fr Date: Sun, 11 Apr 2010 18:12:12 +0200 From: Patrice Mandin To: mint@lists.fishpool.fi Subject: Re: [MiNT] Missing parenthesis in mint/sysvars.h Message-Id: <20100411181212.438469bd.mandin.patrice@orange.fr> In-Reply-To: <4BBF9C71.9010309@freesbee.fr> References: <20100409231102.bef316ee.mandin.patrice@orange.fr> <4BBF9C71.9010309@freesbee.fr> Organization: Chez moi X-Mailer: Sylpheed 2.5.0 (GTK+ 2.12.12; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 X-ecartis-version: Ecartis v1.0.0 Sender: mint-bounce@lists.fishpool.fi Errors-to: mint-bounce@lists.fishpool.fi X-original-sender: mandin.patrice@orange.fr Precedence: bulk List-help: List-unsubscribe: List-Id: X-List-ID: List-subscribe: List-owner: List-post: Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.sparemint.org id o3BGDwc5013887 Le Fri, 09 Apr 2010 23:30:25 +0200 Vincent Rivière a écrit: > Patrice Mandin wrote: > > There is a missing ( for the definition of vblsem, in mint/sysvars.h: > > #define vblsem ((short *) 0x452L)) /* vbl semaphore */ > > > > It should be: > > #define vblsem (((short *) 0x452L)) /* vbl semaphore */ > > Or better, the last closing one should be removed. I simply propose fixing the way other values are #defined in this file, because it breaks compilation of software using vblsem (currently radeon driver for ctpci). I suppose there was a reason to do: #define value (( (type) address )) instead of #define value ( (type) address ) -- Patrice Mandin WWW: http://pmandin.atari.org/ Programmeur Linux, Atari Spécialité: Développement, jeux