From mint-bounce@lists.fishpool.fi Mon Apr 12 18:06:06 2010 Message-ID: <4BC398BD.2070804@freesbee.fr> Date: Tue, 13 Apr 2010 00:03:41 +0200 From: =?ISO-8859-1?Q?Vincent_Rivi=E8re?= User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.9.1.9) Gecko/20100317 Thunderbird/3.0.4 MIME-Version: 1.0 To: mint@lists.fishpool.fi Subject: Re: [MiNT] [MiNT][patch] Missing parenthesis in mint/sysvars.h References: <20100409231102.bef316ee.mandin.patrice@orange.fr> <4BBF9C71.9010309@freesbee.fr> <20100411181212.438469bd.mandin.patrice@orange.fr> <4BC2DF26.5080502@freesbee.fr> In-Reply-To: <4BC2DF26.5080502@freesbee.fr> Content-Type: multipart/mixed; boundary="------------070602040508040604040402" X-Antivirus: avast! (VPS 100412-2, 12/04/2010), Outbound message X-Antivirus-Status: Clean X-ecartis-version: Ecartis v1.0.0 Sender: mint-bounce@lists.fishpool.fi Errors-to: mint-bounce@lists.fishpool.fi X-original-sender: vincent.riviere@freesbee.fr Precedence: bulk List-help: List-unsubscribe: List-Id: X-List-ID: List-subscribe: List-owner: List-post: This is a multi-part message in MIME format. --------------070602040508040604040402 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Vincent Rivi=E8re wrote: > The file is quite small, all the additional parenthesis should be > removed, so the consistency will be kept. And here is a patch for that. Alan, please commit with the following description: Removed unnecessary parentheses. Contributed by Vincent Riviere. --=20 Vincent Rivi=E8re --------------070602040508040604040402 Content-Type: text/plain; name="sysvars.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="sysvars.patch" diff -aurN -x CVS mintlib.orig/include/mint/sysvars.h mintlib/include/mint/sysvars.h --- mintlib.orig/include/mint/sysvars.h 2010-04-12 23:13:23.468750000 +0200 +++ mintlib/include/mint/sysvars.h 2010-04-12 23:58:02.140625000 +0200 @@ -35,14 +35,14 @@ /* timer, crit error and process termination handoff vectors */ -#define etv_timer (((void (**)()) 0x400L)) -#define etv_critic (((void (**)()) 0x404L)) -#define etv_term (((void (**)()) 0x408L)) +#define etv_timer ((void (**)()) 0x400L) +#define etv_critic ((void (**)()) 0x404L) +#define etv_term ((void (**)()) 0x408L) /* memory controller */ #define MEMVALID_MAGIC 0x752019F3L /* once memory is sized */ -#define memvalid (((unsigned long *) 0x420L)) -#define mencntlr (((unsigned char *) 0x424L)) +#define memvalid ((unsigned long *) 0x420L) +#define mencntlr ((unsigned char *) 0x424L) /* 0 = 128K, 4 = 512K 0 = 256k(2banks) 5 = 1M */ /* reset vector, jump through resvector if resvalid on reset */ @@ -52,36 +52,36 @@ /* do a jmp 0x24L(a6) at end to go to system reset */ /* mem */ -#define phystop (((unsigned long *) 0x42eL)) /* physical top of st ram */ -#define _membot (((unsigned long *) 0x432L)) /* bottom of avail */ -#define _memtop (((unsigned long *) 0x436L)) /* top of avail */ +#define phystop ((unsigned long *) 0x42eL) /* physical top of st ram */ +#define _membot ((unsigned long *) 0x432L) /* bottom of avail */ +#define _memtop ((unsigned long *) 0x436L) /* top of avail */ #define MEMVAL2_MAGIC 0x237698AAL /* after suc. coldstart && memvalid */ -#define memval2 (((unsigned long *) 0x43aL)) -#define ramtop (((unsigned long *) 0x5a4L)) /* physical top of tt ram */ +#define memval2 ((unsigned long *) 0x43aL) +#define ramtop ((unsigned long *) 0x5a4L) /* physical top of tt ram */ /* floppy */ -#define flock (((short *) 0x43eL)) /* lock usage of DMA chip */ -#define seekrate (((short *) 0x440L)) /* 0=6ms 1=12ms 2=2ms 3=3ms */ -#define _timr_ms (((short *) 0x442L)) /* timer calib == 20ms */ -#define _fverify (((short *) 0x444L)) /* write verify flag */ -#define _bootdev (((short *) 0x446L)) +#define flock ((short *) 0x43eL) /* lock usage of DMA chip */ +#define seekrate ((short *) 0x440L) /* 0=6ms 1=12ms 2=2ms 3=3ms */ +#define _timr_ms ((short *) 0x442L) /* timer calib == 20ms */ +#define _fverify ((short *) 0x444L) /* write verify flag */ +#define _bootdev ((short *) 0x446L) /* video */ -#define palmode (((short *) 0x448L)) /* PAL video mode flag */ -#define defshiftmd (((unsigned char *) 0x44aL)) /* default video rez */ -#define sshiftmd (((short *) 0x44cL)) /* shadow of hdwr. shiftmd reg */ - /* 0=Lo 1=med 2=Hi rez */ -#define _v_bas_ad (((void *) 0x44eL)) /* screen mem base */ -#define vblsem (((short *) 0x452L)) /* vbl semaphore */ -#define nvbls (((short *) 0x454L)) /* # of vbl entries def. == 8 */ -#define _vblqueue (((void (***)()) 0x456L)) /* vbl queue pointer */ -#define colorptr (((short **) 0x45aL)) /* pal. on next vblank if!NULL */ -#define _vbclock (((unsigned long *) 0x462L)) /* vbi counter */ -#define _frclock (((unsigned long *) 0x466L)) /* #vbi not vblsem'ed */ +#define palmode ((short *) 0x448L) /* PAL video mode flag */ +#define defshiftmd ((unsigned char *) 0x44aL) /* default video rez */ +#define sshiftmd ((short *) 0x44cL) /* shadow of hdwr. shiftmd reg */ + /* 0=Lo 1=med 2=Hi rez */ +#define _v_bas_ad ((void *) 0x44eL) /* screen mem base */ +#define vblsem ((short *) 0x452L) /* vbl semaphore */ +#define nvbls ((short *) 0x454L) /* # of vbl entries def. == 8 */ +#define _vblqueue ((void (***)()) 0x456L) /* vbl queue pointer */ +#define colorptr ((short **) 0x45aL) /* pal. on next vblank if!NULL */ +#define _vbclock ((unsigned long *) 0x462L) /* vbi counter */ +#define _frclock ((unsigned long *) 0x466L) /* #vbi not vblsem'ed */ #define _hz_200 ((unsigned long *) 0x4baL) -#define conterm (*((char *) 0x484L)) +#define conterm (*(char *) 0x484L) #define savptr ((long *) 0x4A2L) #define _nflops ((short *) 0x4A6L) #define _sysbase ((long *) 0x4F2L) --------------070602040508040604040402--