From mint-bounce@lists.fishpool.fi  Sun May 23 05:43:50 2010
Message-ID: <4BF8F86B.7050706@online.no>
Date: Sun, 23 May 2010 11:42:03 +0200
From: Jo Even Skarstein <joska@online.no>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100423 Thunderbird/3.0.4
MIME-Version: 1.0
To: mint@lists.fishpool.fi
Subject: Re: [MiNT] typo in keyboard.c
References: <op.vc5dfkfmofd6j1@descaro.mshome.net>
In-Reply-To: <op.vc5dfkfmofd6j1@descaro.mshome.net>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
X-ecartis-version: Ecartis v1.0.0
Sender: mint-bounce@lists.fishpool.fi
Errors-to: mint-bounce@lists.fishpool.fi
X-original-sender: joska@online.no
Precedence: bulk
List-help: <mailto:ecartis@lists.fishpool.fi?Subject=help>
List-unsubscribe: <mailto:mint-request@lists.fishpool.fi?Subject=unsubscribe>
List-Id: <mint.lists.fishpool.fi>
X-List-ID: <mint.lists.fishpool.fi>
List-subscribe: <mailto:mint-request@lists.fishpool.fi?Subject=subscribe>
List-owner: <mailto:tjhukkan@fishpool.fi>
List-post: <mailto:mint@lists.fishpool.fi>

On 05/23/2010 09:22 AM, Helmut Karlowski wrote:
> There's a typo in line 160 in keyboard.c:
> 
> static char makes[MAKES_BLEN + 1 * 2];
> 
> should be:
> 
> static char makes[MAKES_BLEN * 2 + 1];
> 
> or even:
> 
> static char makes[MAKES_BLEN * 2 - 1];

I just had a look myself to see if this affects the Milan, which it
doesn't as it's not used on a Milan. However, I see that it's
initialized in init_keybd (also on the Milan), and only the first
MAKES_BLEND bytes are initialized. So on the Milan, no damage is done.

Jo Even