From mint-bounce@lists.fishpool.fi Wed Aug 11 06:42:23 2010 Message-ID: <4C627DFB.3040305@freesbee.fr> Date: Wed, 11 Aug 2010 12:39:55 +0200 From: =?ISO-8859-1?Q?Vincent_Rivi=E8re?= User-Agent: Thunderbird 2.0.0.24 (Windows/20100228) MIME-Version: 1.0 To: mint@lists.fishpool.fi Subject: Re: [MiNT] trunk-09082010 file structure / content References: <1281389959.4401.204.camel@jetpack.demon.co.uk> <1281398029.4401.343.camel@jetpack.demon.co.uk> <1281425999.4401.816.camel@jetpack.demon.co.uk> <1281438486.4401.1029.camel@jetpack.demon.co.uk> <1281442675.3015.43.camel@jetpack.demon.co.uk> <4C615968.6070600@atari-source.org> <4C616E79.4080700@freesbee.fr> <4C617B24.60201@atari-source.org> <6013b8c390335c274c8ab71bdd1be52c-EhVcX1lFRQVaRwYcDTpQCEFddQZLVF5dQUNBAjBTXF5bVkYJXlZoBl06XF1XQEEEXlxZQg==-webmailer1@server08.webmailer.hosteurope.de> <4C6196FD.9070203@atari-source.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-Antivirus: avast! (VPS 100811-0, 11/08/2010), Outbound message X-Antivirus-Status: Clean X-ecartis-version: Ecartis v1.0.0 Sender: mint-bounce@lists.fishpool.fi Errors-to: mint-bounce@lists.fishpool.fi X-original-sender: vincent.riviere@freesbee.fr Precedence: bulk List-help: List-unsubscribe: List-Id: X-List-ID: List-subscribe: List-owner: List-post: Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.sparemint.org id o7BAgNc0016348 Miro Kropacek wrote: > # ifdef M68060 > r = 0x0000003cL; /* 060 kernel */ > # endif > # ifdef M68040 > r = 0x00000028L; /* 040 kernel */ > # endif > # ifdef M68030 > r = 0x0000001eL; /* 030 kernel */ > # endif > > You see, it's not only awkward to see something like this but it's > also harder to read / maintain / change (imagine someone would like to > redefine meaning of these numbers -- he would need to compile four > kernels (000, 030, 040, 060) to see if he didn't break something). I think it is a normal situation to have to recompile any version after making such a change. Furthermore, robust software has a testsuite to automate the regression checks, and good testsuites are easy to run. I agree we currently don't have a testsuite for FreeMiNT, and it is not easy for CPU specific stuff, but with good, flexible emulators, it could be possible. And also, in this case, it would be a lot more readable to change: r = 0x0000003cL; /* 060 kernel */ by r = 60; /* 060 kernel */ -- Vincent Rivière