From mint-bounce@lists.fishpool.fi Fri Aug 6 12:35:32 2010 Message-ID: <673106.463250832-sendEmail@descaro> From: "Helmut Karlowski" To: "mint@lists.fishpool.fi" Cc: "helmut.karlowski@ish.de" Subject: Re: [MiNT] Shutdown error Date: Fri, 6 Aug 2010 16:33:21 +0000 X-Mailer: sendEmail-1.55 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----MIME delimiter for sendEmail-841885.139540867" X-Antivirus: avast! (VPS 100806-0, 06.08.2010), Outbound message X-Antivirus-Status: Clean X-ecartis-version: Ecartis v1.0.0 Sender: mint-bounce@lists.fishpool.fi Errors-to: mint-bounce@lists.fishpool.fi X-original-sender: helmut.karlowski@ish.de Precedence: bulk List-help: List-unsubscribe: List-Id: X-List-ID: List-subscribe: List-owner: List-post: This is a multi-part message in MIME format. To properly display this message you need a MIME-Version 1.0 compliant Email program. ------MIME delimiter for sendEmail-841885.139540867 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Peter Slegg wrote: > On Fri, 6 Aug 2010 13:11:11 , Helmut Karlowski wrote: > > > > Damn! I had to redo some shutdown-stuff. There's still a problem, I will > > describe later. > > > > So I've uploaded a new binary .. > > > > Tell me if it works :) > > > > -Helmut > > > That seems to be ok as well. Good. So here's what happens: 1. shutdown sends SIGTERM to most processes including the one started by mint.cnf (GEM=, INIT=). When this process exits, the loop in init.c is terminated, and shutdown is started (again). So I prevented shutdown to send SIGTERM to GEM, and some other processes that could be INIT. In xaloader (and XaAES) SIGTERM is ignored, so this is no problem. Now also the process with pid 1 is not terminated by shutdown. A previous version used ppid==0 but this is valid for some more processes. Another one used a flag (that's Peters version) wich also works but pid 1 is much simpler. 2. Another issue I encountered is when shutdown calls yield (I assume to give SIGTERMed processes time to exit) that maybe they use resources that do not exist anymore because other processes already exited (theory). At least a (korn-) shell started by toswin and running e.g. top when Halt is selected would crash because it ignores the SIGTERM. So I removed the yield() and no crash occures. I'm not 100% sure if this is a perfect solution. (diffs is attached - should I commit this as is to trunk?) -Helmut ------MIME delimiter for sendEmail-841885.139540867 Content-Type: application/octet-stream; name="diffs" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="diffs" LS0tIGRvcy5jCTUgQXVnIDIwMTAgMTg6NTI6MzggLTAwMDAJMS4zMworKysgZG9zLmMJNiBBdWcg MjAxMCAxNjozMDoyMCAtMDAwMApAQCAtNjUzLDkgKzY1Myw5IEBACiAJZm9yIChwID0gcHJvY2xp c3Q7IHA7IHAgPSBwLT5nbF9uZXh0KQogCXsKIAkJbHMucyA9IHAtPm5hbWU7Ci0JCUZPUkNFKCJw LT5uYW1lPSVzOiVseCBwZ3JwPSVkIiwgcC0+bmFtZSwgbHMubCwgcC0+cGdycCk7Ci0JCS8qIFNr aXAgTWlOVCwgY3VycHJvYyBhbmQgQUVTLCBhbmQgR0VNICovCi0JCWlmIChwLT5wZ3JwICYmIChw ICE9IGdldF9jdXJwcm9jKCkpICYmICgocC0+cF9tZW0tPm1lbWZsYWdzICYgRl9PU19TUEVDSUFM KSA9PSAwKSAmJiBscy5sICE9IEdFTSApCisJCURFQlVHKCgicD0lbHggcC0+bmFtZT0lczolbHgg cGdycD0lZCBtZW1mbGFncz0leCBtb2RlZmxhZ3M9JXgiLCBwLCBwLT5uYW1lLCBscy5sLCBwLT5w Z3JwLCBwLT5wX21lbS0+bWVtZmxhZ3MsIHAtPm1vZGVmbGFncykpOworCQkvKiBTa2lwIE1pTlQs IGluaXQgKHBpZCAxKSwgY3VycHJvYyBhbmQgQUVTLCBhbmQgR0VNICovCisJCWlmIChwLT5wZ3Jw ICYmIHAtPnBpZCA+IDEgJiYgIShwLT5wX21lbS0+bWVtZmxhZ3MgJiBGX09TX1NQRUNJQUwpICYm IGxzLmwgIT0gR0VNICkKIAkJewogCQkJaWYgKHAtPndhaXRfcSAhPSBaT01CSUVfUSAmJiBwLT53 YWl0X3EgIT0gVFNSX1EpCiAJCQl7CkBAIC02NjcsMjMgKzY2NywzMCBAQAogCQkJCQlzcGwoc3Ip OwogCQkJCX0KIAotCQkJCUZPUkNFKCJTSUdURVJNIC0+ICVzIChwaWQgJWkpIiwgcC0+bmFtZSwg cC0+cGlkKTsKKwkJCQlERUJVRygoIlNJR1RFUk0gLT4gJXMgKHBpZCAlaSkiLCBwLT5uYW1lLCBw LT5waWQpKTsKIAkJCQlwb3N0X3NpZyhwLCBTSUdURVJNKTsKIAogCQkJCXBvc3RzKys7CiAJCQl9 CiAJCX0KIAl9Ci0KKwkvKiBnaXZlIFNJR1RFUk1lZCBwcm9jZXNzZXMgdGltZSB0byBleGl0Lgor CSAqIHByb2JsZW0gbWF5IGJlIHRoZXkgdXNlIHJlc291cmNlcyB0aGF0IGRvCisJICogbm90IGV4 aXN0IGFueW1vcmUgYmVjYXVzZSBvdGhlciBwcm9jZXNzZXMKKwkgKiBhbHJlYWR5IGV4aXRlZCAo dGhlb3J5KS4KKwkgKi8KKyNpZiAwCisJRk9SQ0UoInlpZWxkaW5nIik7CiAJd2hpbGUgKHBvc3Rz LS0pCiAJCWZvciAoaSA9IDA7IGkgPCAxNjsgaSsrKQkvKiBzbGVlcCAqLwogCQkJc3lzX3NfeWll bGQoKTsKLQorI2VuZGlmCisJRk9SQ0UoInN5c3FbUkVBRFlfUV0uaGVhZCA9IHN5c3FbUkVBRFlf UV0udGFpbCA9IE5VTEw7Iik7CiAJc3lzcVtSRUFEWV9RXS5oZWFkID0gc3lzcVtSRUFEWV9RXS50 YWlsID0gTlVMTDsKIAotCUZPUkNFKCJDbG9zZSBvcGVuIGZpbGVzIC4uLiIpOworCS8vRk9SQ0Uo IkNsb3NlIG9wZW4gZmlsZXMgLi4uIik7CiAJY2xvc2VfZmlsZXN5cygpOwotCUZPUkNFKCJkb25l Iik7CisJLy9GT1JDRSgiZG9uZSIpOwogCiAJRk9SQ0UoIlN5bmNpbmcgZmlsZSBzeXN0ZW1zIC4u LiIpOwogCXN5c19zX3luYygpOwotLS0gaW5pdC5jCTEzIEphbiAyMDEwIDE3OjEzOjQ5IC0wMDAw CTEuMTIxCisrKyBpbml0LmMJNiBBdWcgMjAxMCAxNjozMDoyMCAtMDAwMApAQCAtMjA2LDcgKzIw Niw3IEBACiAJcmV0dXJuIGFlc19nbG9ibFswXTsKIH0KIAotc3RhdGljIGxvbmcgR0VNX21lbWZs YWdzID0gRl9GQVNUTE9BRCB8IEZfQUxUTE9BRCB8IEZfQUxUQUxMT0MgfCBGX1BST1RfUzsKK3N0 YXRpYyBsb25nIEdFTV9tZW1mbGFncyA9IEZfRkFTVExPQUQgfCBGX0FMVExPQUQgfCBGX0FMVEFM TE9DIHwgRl9QUk9UX1MgfCBGX09TX1NQRUNJQUwgLyo/Ki87CiBleHRlcm4gaW50IGRlYnVnX2xl dmVsOwogdm9pZAogaW5pdCAodm9pZCkK ------MIME delimiter for sendEmail-841885.139540867--